Generalize RET for vec logical and comparison ops#675
Merged
gmlueck merged 2 commits intoKhronosGroup:mainfrom Apr 3, 2025
Merged
Generalize RET for vec logical and comparison ops#675gmlueck merged 2 commits intoKhronosGroup:mainfrom
gmlueck merged 2 commits intoKhronosGroup:mainfrom
Conversation
This is change 8 of 9 that fix problems with the specification of the `vec` class. An implementation that follows the existing specification would not accept common code patterns and would not pass the CTS. None of the existing implementations actually follow the existing specification. This change clarifies the return type for the comparison and logical operators. All of these operators return a vec of integers, where the size of the integer elements depends on the element types of the input operands. The previous wording only specified the return type for certain `DataT` types, leaving other types unspecified. Reword this in a general way which applies to all `DataT` types. These changes correspond to slide 27 of the presentation that was discussed in the WG meetings.
TApplencourt
approved these changes
Apr 3, 2025
Contributor
|
WG approved to merge. |
gmlueck
added a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Apr 4, 2025
Cherry pick KhronosGroup#675 from main (cherry picked from commit ca7dcbf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is change 8 of 9 that fix problems with the specification of the
vecclass. An implementation that follows the existing specification would not accept common code patterns and would not pass the CTS. None of the existing implementations actually follow the existing specification.This change clarifies the return type for the comparison and logical operators. All of these operators return a vec of integers, where the size of the integer elements depends on the element types of the input operands. The previous wording only specified the return type for certain
DataTtypes, leaving other types unspecified. Reword this in a general way which applies to allDataTtypes.These changes correspond to slide 27 of the presentation that was discussed in the WG meetings.